Ncto 141 add image upload on project settings by Louis-rollet · Pull Request #19 · Naucto/Backend

Louis-rollet · 2026-03-15T13:14:16Z

Jira ticket

https://naucto.atlassian.net/browse/NCTO-141

What does your MR do ?

Linked to frontend PR, this will add the way to upload images on the S3 then will be able to laod then using the cdn urls, currently it's implemented on ongoing projects and published projects.
The backend adds the apis to be able to upload and get the images of user profiles or projects

How to test it

Open a project and in the project settings you can now upload an image for this project

Screenshot

Notes

…ttings and public routes

Copilot

Pull request overview

Adds backend support for uploading project/user images to S3 and retrieving their CDN URLs, including new unauthenticated (“public”) endpoints intended for published projects and user profile pictures.

Changes:

Tightens image upload validation (max size + MIME type) for project images and user profile pictures.
Updates project image retrieval to return a CDN URL payload and adds new public endpoints to fetch CDN URLs for published project images and user profile pictures.
Extends Swagger/OpenAPI documentation to reflect new endpoints and updated response shapes.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
swagger.json	Updates OpenAPI docs for image upload validation/errors, changes project image GET response, and adds new public image URL endpoints + schema.
src/swagger.app.module.ts	Registers `PublicController` in the Swagger-only module for documentation generation.
src/routes/user/user.controller.ts	Adds image MIME validation and sets uploaded profile pictures to public-read.
src/routes/public/public.module.ts	Introduces a new module wiring Prisma + S3 for the public routes.
src/routes/public/public.controller.ts	Adds public endpoints to fetch CDN URLs for published project images and user profile pictures.
src/routes/public/dto/image-url-response.dto.ts	Adds a DTO for `{ url }` responses.
src/routes/project/project.controller.ts	Adds collaborator guard for upload/get image, validates MIME type, switches GET image response to `{ url }`, and sets uploaded project images to public-read.
src/app.module.ts	Registers `PublicModule` in the main app module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/routes/project/project.controller.ts

  @ApiResponse({
    status: 200,
-    description: "Signed cookies and CDN resource URL",
-    type: SignedCdnResourceDto
+    description: "CDN URL for the project image",
+    schema: {
+      type: "object",
+      properties: {
+        url: { type: "string", example: "https://cdn.example.com/projects/42/image" }
+      }
+    }
  })
+  @ApiResponse({ status: 403, description: "Forbidden" })
  @ApiResponse({ status: 404, description: "Image not found" })
  async getProjectImage(
-    @Param("id", ParseIntPipe) id: number,
-    @Res() res: Response
-  ): Promise<void> {
+    @Param("id", ParseIntPipe) id: number
+  ): Promise<{ url: string }> {


alexis-belmonte · 2026-03-15T16:09:00Z

src/routes/public/public.controller.ts

+    const project = await this.prismaService.project.findUnique({
+      where: { id },
+      select: { id: true, status: true }
+    });
+
+    if (!project) {
+      throw new NotFoundException(`Project with ID ${id} not found`);
+    }
+
+    if (project.status !== "COMPLETED") {
+      throw new NotFoundException(
+        `Project with ID ${id} is not published`
+      );
+    }


Good suggestion from Copilot

src/routes/public/public.controller.ts

+      throw new NotFoundException(`User with ID ${id} not found`);
+    }
+
+    const key = `users/${id}/profile`;
+    const exists = await this.s3Service.fileExists(key);
+    if (!exists) {
+      throw new NotFoundException("Profile picture not found");


src/routes/user/user.controller.ts

        originalName: file.originalname
      }
    });
+    await this.s3Service.setObjectPublicRead(key);


swagger.json

+                  "type": "object",
+                  "properties": {
+                    "url": {
+                      "type": "string",
+                      "example": "https://cdn.example.com/projects/42/image"
+                    }
+                  }


src/routes/project/project.controller.ts

        originalName: file.originalname
      }
    });
+    await this.s3Service.setObjectPublicRead(key);


alexis-belmonte

Good work!

alexis-belmonte · 2026-03-15T16:07:59Z

src/routes/user/user.controller.ts

        originalName: file.originalname
      }
    });
+    await this.s3Service.setObjectPublicRead(key);


Ehh we can ignore this

not really otherwise we cannot have access to the ressource with the cdn

alexis-belmonte · 2026-03-15T16:09:00Z

src/routes/public/public.controller.ts

+    const project = await this.prismaService.project.findUnique({
+      where: { id },
+      select: { id: true, status: true }
+    });
+
+    if (!project) {
+      throw new NotFoundException(`Project with ID ${id} not found`);
+    }
+
+    if (project.status !== "COMPLETED") {
+      throw new NotFoundException(
+        `Project with ID ${id} is not published`
+      );
+    }


Good suggestion from Copilot

alexis-belmonte · 2026-03-15T16:09:13Z

src/routes/public/public.controller.ts

+    const key = `projects/${id}/image`;
+    const exists = await this.s3Service.fileExists(key);
+    if (!exists) {
+      throw new NotFoundException("Project image not found");


Should be here a NoContentException (if it exists?)

alexis-belmonte · 2026-03-15T16:12:37Z

src/routes/public/public.controller.ts

I believe the routes should be moved to their respective controllers over creating a new controller.

alexis-belmonte · 2026-03-15T16:13:33Z

src/routes/common/dto/image-url-response.dto.ts

Put this in routes/common/dto/...

…roject and user images

…rol and metadata handling

Priax

Looks good to me

[PROJECT] [UPDATE] Implement image upload functionality in project se…

7f32e3d

…ttings and public routes

Louis-rollet requested review from Priax, alexis-belmonte and Copilot March 15, 2026 13:14

Copilot started reviewing on behalf of Louis-rollet March 15, 2026 13:14 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

alexis-belmonte requested changes Mar 15, 2026

View reviewed changes

[PROJECT] [UPDATE] image upload functionality and public access for p…

ba02b22

…roject and user images

Louis-rollet requested a review from alexis-belmonte March 22, 2026 08:15

[PROJECT] [UPDATE] Enhance image upload and retrieval with cache cont…

6e0344c

…rol and metadata handling

Priax approved these changes Mar 22, 2026

View reviewed changes

alexis-belmonte approved these changes Mar 22, 2026

View reviewed changes

Louis-rollet merged commit fea65bf into main Mar 29, 2026
2 checks passed

Louis-rollet deleted the NCTO-141-add-image-upload-on-project-settings branch March 29, 2026 10:53

Conversation

Louis-rollet commented Mar 15, 2026

Jira ticket

What does your MR do ?

How to test it

Screenshot

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexis-belmonte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Priax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants